Skip to content

Ensure cuda is a namespace package & Improve warnings #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 21, 2025
Merged

Ensure cuda is a namespace package & Improve warnings #493

merged 7 commits into from
Apr 21, 2025

Conversation

leofang
Copy link
Member

@leofang leofang commented Mar 6, 2025 •
edited
Loading

Close #477. Close #162.

@leofang leofang added this to the cuda-python 12-next, 11-next milestone Mar 6, 2025
@leofang leofang self-assigned this Mar 6, 2025
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Mar 6, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Mar 6, 2025

/ok to test

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@leofang leofang added bug Something isn't working enhancement Any code-related improvements P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Mar 6, 2025
rwgk
rwgk previously approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This certainly looks great to me!

I'm wondering though, what exactly was the reason for adding these files? How much trouble is it to leave some hints in the PR description?

@leofang leofang mentioned this pull request Mar 23, 2025
Merged
@leofang leofang changed the title Ensure cuda is a namespace package Ensure cuda is a namespace package & Improve warnings Apr 4, 2025
@leofang
Copy link
Member Author

leofang commented Apr 4, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Apr 4, 2025

what exactly was the reason for adding these files? How much trouble is it to leave some hints in the PR description?

As part of the epic #493, we need to remove cuda/__init__.py to ensure cuda is a namespace package. The existence of this file has been a source of multiple traps and bugs.

We still kept it around because it used to provide cuda.__version__. Since we have raised a deprecation warning for a few releases, and it is a minor thing, we now remove it entirely.

@leofang leofang marked this pull request as ready for review April 7, 2025 22:18
@leofang
Copy link
Member Author

leofang commented Apr 7, 2025

This is ready for review. I was hoping to address #517 (comment), but it seems the original issue (leading to our weird MANIFEST.in) still persists.

@leofang leofang requested a review from vzhurba01 April 7, 2025 22:23
vzhurba01
vzhurba01 previously approved these changes Apr 8, 2025
View reviewed changes
@leofang
Copy link
Member Author

leofang commented Apr 18, 2025

/ok to test

@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Apr 18, 2025

/ok to test

@leofang, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@leofang
Copy link
Member Author

leofang commented Apr 18, 2025

/ok to test 88144ee

@leofang leofang merged commit db7c854 into NVIDIA:main Apr 21, 2025
73 checks passed
@leofang leofang deleted the cleanup_main_py branch April 21, 2025 15:42
@github-actions GitHub Actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@vzhurba01 vzhurba01 vzhurba01 approved these changes

@rwgk rwgk rwgk left review comments

Assignees

@leofang leofang

Labels
bug Something isn't working cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P0 High priority - Must do!
Projects
None yet
Milestone
cuda-python 12.9.0 & 11.8.7
Development

Successfully merging this pull request may close these issues.

Remove cuda/__init__.py to avoid confusing various tools Turn DeprecationWarning to UserWarning
4 participants
@leofang @rwgk @kkraus14 @vzhurba01