Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add library mode and kernel_builder state allocation with initialization #1115

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Add library mode and kernel_builder state allocation with initialization #1115

merged 6 commits into from
Jan 23, 2024

Conversation

amccaskey
Copy link
Collaborator

@amccaskey amccaskey commented Jan 19, 2024 •
edited
Loading

This moves the work in PR #1090 into this new feature branch. Work by others will build off of this.

Things that still need to be done:

  • Python bindings
  • Testing
  • Update simulators to set state data (custatevec, cutensornet, mgpu)
  • Hook up the ASTBridge
  • Review / refactor InitializeStateOp and LowerToQIR.cpp updates (@schweitzpgi)
  • Verify bit ordering (@boschmitt)

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 19, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@amccaskey amccaskey requested a review from schweitzpgi January 19, 2024 18:04
@bettinaheim bettinaheim deleted the branch NVIDIA:features/qalloc January 19, 2024 18:30
@amccaskey amccaskey reopened this Jan 19, 2024
anthony-santana
anthony-santana reviewed Jan 22, 2024
View reviewed changes
runtime/cudaq/builder/kernel_builder.h Show resolved Hide resolved
runtime/cudaq/builder/kernel_builder.h Outdated Show resolved Hide resolved
runtime/cudaq/qis/qudit.h Show resolved Hide resolved
schweitzpgi
schweitzpgi approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubberstamp to get things started

@amccaskey
first pass
7fae0b3 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
clang format
d14063b 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
docs
40daaf2 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
minor updates
aa0a9e3 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
clang format
942f388 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey @anthony-santana
Update runtime/cudaq/builder/kernel_builder.h
0b447ef 
Co-authored-by: A.M. Santana <39563805+anthony-santana@users.noreply.github.com>
@amccaskey amccaskey merged commit c8c0e6b into NVIDIA:features/qalloc Jan 23, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anthony-santana anthony-santana anthony-santana left review comments

@schweitzpgi schweitzpgi schweitzpgi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amccaskey @schweitzpgi @anthony-santana @bettinaheim