-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Support returning complex numbers from python #1610
Merged
annagrin
merged 30 commits into
NVIDIA:experimental/stateHandling
from
annagrin:kernel-complex-support-return
May 14, 2024
Merged
[python] Support returning complex numbers from python #1610
annagrin
merged 30 commits into
NVIDIA:experimental/stateHandling
from
annagrin:kernel-complex-support-return
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…A/cuda-quantum into kernel-complex-support-return
…A/cuda-quantum into kernel-complex-support-return
…A/cuda-quantum into kernel-complex-support-return
…A/cuda-quantum into kernel-complex-support-return
annagrin
changed the title
Kernel complex support return
[python] Support returning complex numbers from python
May 6, 2024
schweitzpgi
reviewed
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, Anna. A few suggestions and minor nits.
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
schweitzpgi
reviewed
May 10, 2024
schweitzpgi
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks, Anna.
amccaskey
reviewed
May 14, 2024
…A/cuda-quantum into kernel-complex-support-return
annagrin
merged commit May 14, 2024
ed274f9
into
NVIDIA:experimental/stateHandling
112 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the following features to Python kernel functions:
complex
,numpy.complex128
,numpy.complex64
,numpy.float64
,numpy.float32
numbers.Closes: #1608