-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] add qalloc from state in kernel builder mode #1733
Merged
annagrin
merged 38 commits into
NVIDIA:experimental/stateHandling
from
annagrin:qvector-init-from-state-kernel-builder
May 31, 2024
Merged
[python] add qalloc from state in kernel builder mode #1733
annagrin
merged 38 commits into
NVIDIA:experimental/stateHandling
from
annagrin:qvector-init-from-state-kernel-builder
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…A/cuda-quantum into qvector-init-from-state2
…A/cuda-quantum into qvector-init-from-state2
…A/cuda-quantum into qvector-init-from-state2
…A/cuda-quantum into qvector-init-from-state2
…A/cuda-quantum into qvector-init-from-state2
…A/cuda-quantum into qvector-init-from-state2
…A/cuda-quantum into qvector-init-from-state-update
…A/cuda-quantum into qvector-init-from-state-kernel-builder
annagrin
changed the title
[python] Qvector init from state in kernel builder
[python] add qalloc from state in kernel builder mode
May 31, 2024
schweitzpgi
reviewed
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Lots and lots of tests, which is great.
1tnguyen
reviewed
May 31, 2024
1tnguyen
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
annagrin
merged commit May 31, 2024
403a440
into
NVIDIA:experimental/stateHandling
125 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support initializing
qalloc
from state in builder mode in python.CapturedDataStorage
to generate code for capturing states and numpy arraysqalloc(state)
in builder modeCapturedDataStorage
in kernel mode as well.Towards:
#1086
#1107