-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conversion of state vectors at runtime #1755
Merged
schweitzpgi
merged 62 commits into
NVIDIA:experimental/stateHandling
from
annagrin:runtime-vector-convert-fix
Jun 6, 2024
Merged
Fix conversion of state vectors at runtime #1755
schweitzpgi
merged 62 commits into
NVIDIA:experimental/stateHandling
from
annagrin:runtime-vector-convert-fix
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…A/cuda-quantum into qvector-init-from-state2
…A/cuda-quantum into qvector-init-from-state2
…A/cuda-quantum into qvector-init-from-state2
…A/cuda-quantum into qvector-init-from-state2
…A/cuda-quantum into qvector-init-from-state2
…A/cuda-quantum into qvector-init-from-state2
…A/cuda-quantum into qvector-init-from-state-update
…A/cuda-quantum into runtime-vector-convert-fix
…A/cuda-quantum into runtime-vector-convert-fix
schweitzpgi
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. It really simplifies a bunch of the code.
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
…rin/cuda-quantum into runtime-vector-convert-fix
schweitzpgi
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+2
schweitzpgi
reviewed
Jun 5, 2024
schweitzpgi
reviewed
Jun 5, 2024
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
schweitzpgi
reviewed
Jun 5, 2024
schweitzpgi
merged commit Jun 6, 2024
722739e
into
NVIDIA:experimental/stateHandling
125 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct conversion of vectors at runtime
Closes: #1670
Towards: #1086