Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion of state vectors at runtime #1755

Conversation

annagrin
Copy link
Collaborator

@annagrin annagrin commented Jun 3, 2024

Description

Correct conversion of vectors at runtime

  • Make sure we copy correct size from the state when converting the data to the simulation precision.
  • Remove MLIR-based conversion from python code and rely on conversion in the runtime code instead.

Closes: #1670
Towards: #1086

annagrin added 30 commits April 25, 2024 13:11
@annagrin annagrin marked this pull request as ready for review June 5, 2024 02:48
github-actions bot pushed a commit that referenced this pull request Jun 5, 2024
@annagrin annagrin requested a review from schweitzpgi June 5, 2024 15:56
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It really simplifies a bunch of the code.

targettests/execution/from_state_double.cpp Outdated Show resolved Hide resolved
runtime/nvqir/NVQIR.cpp Outdated Show resolved Hide resolved
runtime/nvqir/NVQIR.cpp Outdated Show resolved Hide resolved
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
github-actions bot pushed a commit that referenced this pull request Jun 5, 2024
github-actions bot pushed a commit that referenced this pull request Jun 5, 2024
@annagrin annagrin requested a review from schweitzpgi June 5, 2024 17:50
@annagrin annagrin enabled auto-merge (squash) June 5, 2024 17:53
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

runtime/nvqir/NVQIR.cpp Outdated Show resolved Hide resolved
runtime/nvqir/NVQIR.cpp Outdated Show resolved Hide resolved
runtime/nvqir/NVQIR.cpp Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Jun 5, 2024
annagrin and others added 2 commits June 5, 2024 12:05
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
@annagrin annagrin disabled auto-merge June 5, 2024 19:38
github-actions bot pushed a commit that referenced this pull request Jun 5, 2024
github-actions bot pushed a commit that referenced this pull request Jun 5, 2024
@schweitzpgi schweitzpgi merged commit 722739e into NVIDIA:experimental/stateHandling Jun 6, 2024
125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants