Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++ bridge] Add support for move constructor of std::vector. #2236

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

schweitzpgi
Copy link
Collaborator

Allow the use of the move constructor so that cases such as

std::vector<int> vectorValue(N);
...
return vectorValue;

will compile and simple vectors of arithmetic types may be used. Note that this requires the CUDA-Q runtime to actually return these values to the caller rather than dropping them on the floor after a launched kernel has deactivated. That is not always the case, however, since some launchers do not expect any return value(s).

Description

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
Copy link

github-actions bot commented Oct 1, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
@schweitzpgi schweitzpgi force-pushed the ch-vector.result branch 2 times, most recently from 6ff846b to 6c84862 Compare October 1, 2024 15:24
@schweitzpgi schweitzpgi enabled auto-merge (squash) October 1, 2024 15:25
@schweitzpgi schweitzpgi requested a review from bmhowe23 October 1, 2024 15:41
Copy link
Collaborator

@amccaskey amccaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, lgtm

Copy link

github-actions bot commented Oct 1, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
Copy link

github-actions bot commented Oct 2, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
Copy link

github-actions bot commented Oct 3, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 3, 2024
@schweitzpgi
Copy link
Collaborator Author

schweitzpgi commented Oct 3, 2024

/ok to test

Command Bot: Processing...

Copy link

github-actions bot commented Oct 3, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 3, 2024
Copy link

github-actions bot commented Oct 4, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 4, 2024
@schweitzpgi
Copy link
Collaborator Author

Jobs took so long, the cache was purged out from underneath them.

@NVIDIA NVIDIA deleted a comment from copy-pr-bot bot Oct 4, 2024
Allow the use of the move constructor so that cases such as

	std::vector<int> vectorValue(N);
	...
	return vectorValue;

will compile and simple vectors of arithmetic types may be used.  Note
that this requires the CUDA-Q runtime to actually return these values to
the caller rather than dropping them on the floor after a launched
kernel has deactivated.  That is not always the case, however, since
some launchers do not expect any return value(s).

Extend GKE to deal with calls since inlining may not have happened.

We introduced a bug when we changed when inlining was done in the
pipeline.
CI and is causing PRs to fail frequently. It appears the output from the
executable is often sent to /dev/null.
Copy link

github-actions bot commented Oct 4, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 4, 2024
@schweitzpgi schweitzpgi merged commit ea0a1a1 into NVIDIA:main Oct 4, 2024
129 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
@schweitzpgi schweitzpgi deleted the ch-vector.result branch October 4, 2024 23:02
@bettinaheim bettinaheim added the no release notes Don't list this PR in the release notes label Nov 19, 2024
@bettinaheim bettinaheim added this to the release 0.9.0 milestone Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no release notes Don't list this PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants