-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++ bridge] Add support for move constructor of std::vector. #2236
Conversation
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
6ff846b
to
6c84862
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally, lgtm
f2eda7e
to
e2ef0bb
Compare
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
4f243cb
to
1a5904a
Compare
Command Bot: Processing... |
1a5904a
to
8d15a12
Compare
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Jobs took so long, the cache was purged out from underneath them. |
Allow the use of the move constructor so that cases such as std::vector<int> vectorValue(N); ... return vectorValue; will compile and simple vectors of arithmetic types may be used. Note that this requires the CUDA-Q runtime to actually return these values to the caller rather than dropping them on the floor after a launched kernel has deactivated. That is not always the case, however, since some launchers do not expect any return value(s). Extend GKE to deal with calls since inlining may not have happened. We introduced a bug when we changed when inlining was done in the pipeline.
CI and is causing PRs to fail frequently. It appears the output from the executable is often sent to /dev/null.
793fe50
to
1329c68
Compare
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Allow the use of the move constructor so that cases such as
will compile and simple vectors of arithmetic types may be used. Note that this requires the CUDA-Q runtime to actually return these values to the caller rather than dropping them on the floor after a launched kernel has deactivated. That is not always the case, however, since some launchers do not expect any return value(s).
Description