Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Braket backend fixes: Device region, S3 bucket creation, result processing #2369

Merged
merged 10 commits into from
Nov 12, 2024
Merged

Braket backend fixes: Device region, S3 bucket creation, result processing #2369

merged 10 commits into from
Nov 12, 2024

Conversation

rmshaffer
Copy link
Contributor

Description

  • Always submit requests to Braket in the region of the target device
  • Attempt to create the default S3 bucket for results, if it doesn't exist
  • Process measurement probabilities if raw measurements don't exist

rmshaffer and others added 7 commits November 5, 2024 17:08
@rmshaffer
Autoroute by device region
086c39e 
Signed-off-by: Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com>
@shpface
Add default bucket creation
eaa9626 
Signed-off-by: Stephen Face <shpface@amazon.com>
@rmshaffer
Merge remote-tracking branch 'upstream/main' into feature/braket-devi…
ffe4ac8 
…ce-region
@rmshaffer
Merge remote-tracking branch 'upstream/main' into feature/braket-devi…
3b98f59 
…ce-region

Signed-off-by: Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com>
@rmshaffer
Fix merge error
ff0e5e2 
Signed-off-by: Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com>
@shpface @rmshaffer
Compute measurements from probabilities
d25ad08 
Signed-off-by: Stephen Face <shpface@amazon.com>
@rmshaffer
Corresponding changes to QuEra backend
cf9598a 
Signed-off-by: Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 8, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rmshaffer
DCO Remediation Commit for Ryan Shaffer <3620100+rmshaffer@users.nore…
aa18e36 
…ply.github.com>

I, Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com>, hereby add my Signed-off-by to this commit: ffe4ac8

Signed-off-by: Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com>
@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Nov 9, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

sacpis
sacpis approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @rmshaffer.

@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Nov 12, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@khalatepradnya khalatepradnya enabled auto-merge (squash) November 12, 2024 19:26
@sacpis sacpis disabled auto-merge November 12, 2024 21:57
@sacpis sacpis merged commit 923df42 into NVIDIA:main Nov 12, 2024
213 of 214 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sacpis sacpis sacpis approved these changes

@bettinaheim bettinaheim Awaiting requested review from bettinaheim

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi

@annagrin annagrin Awaiting requested review from annagrin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rmshaffer @khalatepradnya @sacpis @shpface