Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wheel validation fixes #2371

Merged
merged 33 commits into from
Nov 12, 2024
Merged

Wheel validation fixes #2371

merged 33 commits into from
Nov 12, 2024

Conversation

bettinaheim
Copy link
Collaborator

@bettinaheim bettinaheim commented Nov 12, 2024 •
edited
Loading

Also adds the option to pull artifacts from a manually created draft release to publishing.

@bettinaheim
use latest pip for validation
2c87df2 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
to be reverted (skipping most of the publishing)
89ffea1 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
using nvml to detect cuda version
ace6c7e 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
metapackage validation with conda instead of pip only
60f1e12 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
to be reverted - skip testing in deployment
5a9ed1d 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
draft for bypassing gitlab pipeline
6e7ba16 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
access token
88100e6 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
fixing file name
3363098 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
need soem prints
b42d2f6 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
permissions
c02ede9 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
testing
5e30faf 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
pat was missing the workflow permissions
940f9dd 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
skip cleanup if assets were created manually
f23ebe7 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
Revert "to be reverted - skip testing in deployment"
76e0256 
This reverts commit 5a9ed1d.
@bettinaheim
need to check the conda validation
b72f1b0 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
small workflow fixes
c434f3c 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
adding to the readme that pip should be 24 or newer.
0ab3054 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
debugging the failing grep match
9469a97 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
seems that pip is directing to stderr
41a6bdd 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
--signoff
bebadc0 
need to launch pypi server within conda env
@bettinaheim
--signoff
88ecec2 
need to launch pypi server within conda env

Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
Merge branch 'publishing' of https://github.com/NVIDIA/cuda-quantum i…
e750ea1 
…nto publishing
1tnguyen
1tnguyen approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 12, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bettinaheim
Copy link
Collaborator Author

bettinaheim commented Nov 12, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bettinaheim
properly deal with backslashes
354a157 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
more script fixes
1ee0cb7 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
forgot ampersent
20ab43a 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
only resort to querying the nvml if other detection failed
292aede 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
need to go with cuda 12.4 for validation since a newer version is not…
62505b0 
… available for the platform

Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
Revert "to be reverted (skipping most of the publishing)"
0aa4e0f 
This reverts commit 89ffea1.

Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
addressing remaining fixmes from previous prs
ab39c10 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim
Copy link
Collaborator Author

bettinaheim commented Nov 12, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bettinaheim bettinaheim merged commit 5ee8a43 into main Nov 12, 2024
109 of 110 checks passed
@bettinaheim bettinaheim deleted the publishing branch November 12, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1tnguyen 1tnguyen 1tnguyen approved these changes

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23 bmhowe23 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bettinaheim @1tnguyen