-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Python CUDA dependencies resolve for arm64, too #2501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Howe <bhowe@nvidia.com>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Ben Howe <bhowe@nvidia.com>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This reverts commit f4c5e0e.
bmhowe23
commented
Jan 10, 2025
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bettinaheim
approved these changes
Jan 13, 2025
bmhowe23
added a commit
to bmhowe23/cuda-quantum
that referenced
this pull request
Jan 17, 2025
Signed-off-by: Ben Howe <bhowe@nvidia.com>
bmhowe23
added a commit
to bmhowe23/cuda-quantum
that referenced
this pull request
Jan 17, 2025
Signed-off-by: Ben Howe <bhowe@nvidia.com>
bmhowe23
added a commit
to bmhowe23/cuda-quantum
that referenced
this pull request
Jan 17, 2025
Signed-off-by: Ben Howe <bhowe@nvidia.com>
bmhowe23
added a commit
that referenced
this pull request
Jan 18, 2025
Signed-off-by: Ben Howe <bhowe@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1602 did this for x86_64. This is an attempt to do the same for arm64 now. It seems to work on one machine I'm working on, so let's see if this makes it through the CI gauntlet.
Also, try to bump h5py to 3.12 since that version now has binary arm64 wheels provided again.Edit: save this for a separate PR