Skip to content

[core] Add direct simplification of cc.if when condition is a constant. #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schweitzpgi merged 3 commits into from
Apr 19, 2025
Merged

[core] Add direct simplification of cc.if when condition is a constant. #2824

schweitzpgi merged 3 commits into from
Apr 19, 2025

Conversation

@schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Apr 18, 2025

Description

@copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 18, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@schweitzpgi
[core] Add direct simplification of cc.if when condition is a constant.
388e274 
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
@schweitzpgi
Copy link
Collaborator Author

schweitzpgi commented Apr 18, 2025

Addresses one of the issues in #2822 (but not all of them).

@schweitzpgi
Don't fold if there are results.
aaeab86 
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
github-actions bot pushed a commit that referenced this pull request Apr 18, 2025
@cuda-quantum-bot
Docs preview for PR #2824.
bae2f04
@github-actions
Copy link

github-actions bot commented Apr 18, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 18, 2025
@cuda-quantum-bot
Docs preview for PR #2824.
6e387de
@github-actions
Copy link

github-actions bot commented Apr 18, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

bmhowe23
bmhowe23 approved these changes Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Eric.

@schweitzpgi schweitzpgi enabled auto-merge (squash) April 18, 2025 23:39
@schweitzpgi schweitzpgi merged commit d051c72 into NVIDIA:main Apr 19, 2025
196 of 197 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 19, 2025
@cuda-quantum-bot
Cleaning up docs preview for PR #2824.
5a2a9a9
@schweitzpgi schweitzpgi deleted the ch-if.fold branch April 21, 2025 15:31
@bettinaheim bettinaheim added the no release notes Don't list this PR in the release notes label May 5, 2025
@bettinaheim bettinaheim added this to the release 0.11.0 milestone May 5, 2025
annagrin pushed a commit to annagrin/cuda-quantum that referenced this pull request Jun 17, 2025
@schweitzpgi @annagrin
[core] Add direct simplification of cc.if when condition is a constan…
c611d57 
…t. (NVIDIA#2824)

* [core] Add direct simplification of cc.if when condition is a constant.

Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>

* Don't fold if there are results.

Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>

---------

Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@annagrin annagrin Awaiting requested review from annagrin

Assignees

No one assigned

Labels

no release notes Don't list this PR in the release notes

Projects

None yet

Milestone

release 0.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@schweitzpgi @bmhowe23 @bettinaheim