Skip to content

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Jun 24, 2025

Description

This relaxes some pinnings on numba-cuda, numba, and pandas to ensure that the latest nightly of cudf can be used. I also removed the nvidia channel as it is no longer needed.

This also fixes cuopt_cli test which was failing due to missing pyenv

@bdice bdice requested a review from a team as a code owner June 24, 2025 16:28
@bdice bdice requested a review from gforsyth June 24, 2025 16:28
@bdice bdice added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jun 24, 2025
Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of these changes also need to be set in the rattler recipes

@bdice bdice requested a review from gforsyth June 24, 2025 16:52
@bdice
Copy link
Contributor Author

bdice commented Jun 24, 2025

Good call @gforsyth, normally I catch myself on that but not this time!

Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rgsl888prabhu
Copy link
Collaborator

Thank you @bdice for the PR.

@bdice bdice requested a review from a team as a code owner June 24, 2025 16:58
@bdice bdice requested a review from tmckayus June 24, 2025 16:58
@bdice
Copy link
Contributor Author

bdice commented Jun 24, 2025

@rgsl888prabhu Could you take a quick peek at the install instructions? I just pushed some simplifications there while I was ripping out -c nvidia. We don't need to specify Python and CUDA minor versions in our install commands, it's best to let conda figure that out. It will work better with existing environments, and requires fewer updates on our side for every new CUDA/Python release.

@rgsl888prabhu
Copy link
Collaborator

@rgsl888prabhu Could you take a quick peek at the install instructions? I just pushed some simplifications there while I was ripping out -c nvidia. We don't need to specify Python and CUDA minor versions in our install commands, it's best to let conda figure that out. It will work better with existing environments, and requires fewer updates on our side for every new CUDA/Python release.

cuOpt packages are in nvidia channel, I think intsall instruction would require nvidia channel for cuOpt. https://anaconda.org/nvidia/repo

@bdice
Copy link
Contributor Author

bdice commented Jun 24, 2025

Sorry. Then my advice about removing nvidia only applies to RAPIDS and not cuOpt... I'll revert those changes.

@rgsl888prabhu
Copy link
Collaborator

@bdice I am working on fixing the error in tests, will push it to this PR and also revert changes to README

@rgsl888prabhu
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit d8bdad5 into NVIDIA:branch-25.08 Jun 24, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants