Skip to content

Remove unused and broken build flags #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 3 commits into from
May 20, 2025
Merged

Remove unused and broken build flags #15

rapids-bot merged 3 commits into from
May 20, 2025

Conversation

@rg20
Copy link
Contributor

@rg20 rg20 commented May 19, 2025

This PR removes the following build flags:

  1. cpp-mgtests: This is unused
  2. no-fetch-rapids: This is broken in the latest version of rapids, this needs to be fixed to improve build times
  3. skip_l1_tests: This is unused
  4. d: The development build flag is unused

@rg20 rg20 requested a review from a team as a code owner May 19, 2025 13:52
@rg20 rg20 requested a review from rgsl888prabhu May 19, 2025 13:52
@copy-pr-bot
Copy link

copy-pr-bot bot commented May 19, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rg20 rg20 added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels May 19, 2025
@rg20 rg20 force-pushed the remove_unused_broken_flags branch from ba042c4 to 694a9e7 Compare May 19, 2025 13:59
@rg20
Copy link
Contributor Author

rg20 commented May 19, 2025

/ok to test 2c34a07

@chris-maes chris-maes added this to the 25.05 milestone May 19, 2025
@tmckayus
Copy link
Contributor

tmckayus commented May 20, 2025

@rgsl888prabhu lgtm, what do you think?

@rg20
Copy link
Contributor Author

rg20 commented May 20, 2025

/merge

@rapids-bot rapids-bot bot merged commit b3a493a into NVIDIA:branch-25.05 May 20, 2025
83 checks passed
@rg20 rg20 deleted the remove_unused_broken_flags branch May 22, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmckayus tmckayus tmckayus approved these changes

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu rgsl888prabhu is a code owner automatically assigned from NVIDIA/cuopt-infra-codeowners

Assignees

@rgsl888prabhu rgsl888prabhu

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

25.05

Development

Successfully merging this pull request may close these issues.

4 participants

@rg20 @tmckayus @rgsl888prabhu @chris-maes