-
Notifications
You must be signed in to change notification settings - Fork 111
Split very large tests into smaller individual test cases #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e917c42 to
28b7231
Compare
|
/ok to test 28b7231 |
|
Hi @rg20 ! Is there anything else I need to do to get this PR merged? |
|
/ok to test 28b7231 |
Hi @vitor1001 I just kicked off CI. I will merge after tests pass. |
28b7231 to
0175738
Compare
|
Hopfully fixed the tests, please take another look! |
|
/ok to test ecd37cc |
@vitor1001 if you make any code changes including merges are fast-forwards after the the tests pass, we will have to run the tests again. If there are no real conflicts, its usually okay to not do the merges. rerunning the tests now. |
Thanks for the hint, but in this case my change did actually broke the test in some configs. So I guessed that re-running to validate was necessary anyway. |
|
Hi @rg20, all tests seem to pass. Anything else you need from my side? |
|
/merge |
Checklist