Skip to content

Conversation

@vitor1001
Copy link
Contributor

@vitor1001 vitor1001 commented Jun 26, 2025

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vitor1001 vitor1001 force-pushed the test_improvement branch 2 times, most recently from e917c42 to 28b7231 Compare June 26, 2025 15:53
@vitor1001 vitor1001 marked this pull request as ready for review June 26, 2025 15:53
@vitor1001 vitor1001 requested a review from a team as a code owner June 26, 2025 15:53
@vitor1001 vitor1001 requested review from kaatish and rg20 June 26, 2025 15:53
@rg20 rg20 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jun 26, 2025
@rg20
Copy link
Contributor

rg20 commented Jun 26, 2025

/ok to test 28b7231

@vitor1001
Copy link
Contributor Author

Hi @rg20 ! Is there anything else I need to do to get this PR merged?

@anandhkb anandhkb added this to the 25.08 milestone Jul 1, 2025
@rg20
Copy link
Contributor

rg20 commented Jul 1, 2025

/ok to test 28b7231

@rg20
Copy link
Contributor

rg20 commented Jul 1, 2025

Hi @rg20 ! Is there anything else I need to do to get this PR merged?

Hi @vitor1001 I just kicked off CI. I will merge after tests pass.

@vitor1001
Copy link
Contributor Author

Hopfully fixed the tests, please take another look!

@rg20
Copy link
Contributor

rg20 commented Jul 2, 2025

/ok to test ecd37cc

@rg20
Copy link
Contributor

rg20 commented Jul 2, 2025

Hopfully fixed the tests, please take another look!

@vitor1001 if you make any code changes including merges are fast-forwards after the the tests pass, we will have to run the tests again. If there are no real conflicts, its usually okay to not do the merges.

rerunning the tests now.

@vitor1001
Copy link
Contributor Author

@vitor1001 if you make any code changes including merges are fast-forwards after the the tests pass, we will have to run the tests again. If there are no real conflicts, its usually okay to not do the merges.

Thanks for the hint, but in this case my change did actually broke the test in some configs. So I guessed that re-running to validate was necessary anyway.

@vitor1001
Copy link
Contributor Author

Hi @rg20, all tests seem to pass. Anything else you need from my side?

@rg20
Copy link
Contributor

rg20 commented Jul 15, 2025

/merge

@rapids-bot rapids-bot bot merged commit 1d788c6 into NVIDIA:branch-25.08 Jul 15, 2025
140 of 142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants