Skip to content

Fix versioning for nightly and release package #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 1 commit into from
Jul 1, 2025
Merged

Fix versioning for nightly and release package #175

rapids-bot merged 1 commit into from
Jul 1, 2025

Conversation

@rgsl888prabhu
Copy link
Collaborator

@rgsl888prabhu rgsl888prabhu commented Jul 1, 2025 •
edited
Loading

Description

This PR adds changes which updates version based on git tag so that nightly and release packages can be differentiated.

Issue

closes #167

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner July 1, 2025 16:01
@rgsl888prabhu rgsl888prabhu requested a review from vyasr July 1, 2025 16:01
@rgsl888prabhu rgsl888prabhu self-assigned this Jul 1, 2025
@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality breaking Introduces a breaking change and removed non-breaking Introduces a non-breaking change labels Jul 1, 2025
@rgsl888prabhu rgsl888prabhu added this to the 25.08 milestone Jul 1, 2025
@rgsl888prabhu rgsl888prabhu requested a review from jameslamb July 1, 2025 16:01
@rgsl888prabhu rgsl888prabhu changed the title Fix versioning for nightly and release packages Fix versioning for nightly and release package naming Jul 1, 2025
@rgsl888prabhu rgsl888prabhu changed the title Fix versioning for nightly and release package naming Fix versioning for nightly and release package Jul 1, 2025
jameslamb
jameslamb approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.

Spot-checked some logs and see the expected versions, e.g.

Checking 
/tmp/wheelhouse/cuopt_mps_parser-25.8.0a40-cp312-cp312-manylinux_2_24_x86_64.man

(build link)

@gforsyth
Copy link
Contributor

gforsyth commented Jul 1, 2025

Also should have noted in my review, the conda builds are already using rapids-generate-version so there is no additional change needed there.

@rgsl888prabhu
Copy link
Collaborator Author

rgsl888prabhu commented Jul 1, 2025

Also created a follow-up request to delete older wheels with wrong naming https://github.com/rapidsai/ops/issues/4078

@rgsl888prabhu
Copy link
Collaborator Author

rgsl888prabhu commented Jul 1, 2025

/merge

@rapids-bot rapids-bot bot merged commit 24063cc into NVIDIA:branch-25.08 Jul 1, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gforsyth gforsyth gforsyth approved these changes

@jameslamb jameslamb jameslamb approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from NVIDIA/cuopt-ci-codeowners

Assignees

@rgsl888prabhu rgsl888prabhu

Labels

breaking Introduces a breaking change improvement Improves an existing functionality

Projects

None yet

Milestone

25.08

Development

Successfully merging this pull request may close these issues.

[BUG] Nightly cuOpt packages are getting built without "a" in their wheel name

3 participants

@rgsl888prabhu @gforsyth @jameslamb