Skip to content

Conversation

@rgsl888prabhu
Copy link
Collaborator

@rgsl888prabhu rgsl888prabhu commented Jul 2, 2025

Description

Adds workflow for container build, test and push for nightly and release.

Nightly container would have the tag for example 25.8.0a-cuda12.8-py3.12

And these will be published to https://hub.docker.com/r/nvidia/cuopt/tags and ngc internal registry.

This PR also removes several unused workflows and also update license header.

Issue

closes #123

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 2, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jul 2, 2025
@rgsl888prabhu rgsl888prabhu self-assigned this Jul 2, 2025
@rgsl888prabhu rgsl888prabhu marked this pull request as ready for review July 2, 2025 20:22
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner July 2, 2025 20:22
@rgsl888prabhu rgsl888prabhu requested a review from jakirkham July 2, 2025 20:22
@rgsl888prabhu rgsl888prabhu marked this pull request as draft July 2, 2025 22:26
@rgsl888prabhu
Copy link
Collaborator Author

/ok to test

@rgsl888prabhu
Copy link
Collaborator Author

/ok to test 812d751

@rgsl888prabhu
Copy link
Collaborator Author

/ok to test

@rgsl888prabhu rgsl888prabhu marked this pull request as ready for review July 3, 2025 15:22
@rgsl888prabhu
Copy link
Collaborator Author

/ok to test

Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rgsl888prabhu -- I've made it through most of this and flagged up a few questions and changes -- I can take another look after we clarify a bit more on some of the question areas.

@rgsl888prabhu rgsl888prabhu requested a review from gforsyth July 24, 2025 17:54
@rgsl888prabhu
Copy link
Collaborator Author

@gforsyth May I get your review on this

Copy link
Collaborator Author

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gforsyth I have addressed review comments, may I get your review on this

@rgsl888prabhu rgsl888prabhu force-pushed the add_nightly_container_support branch from 7ad250e to e5f1248 Compare July 25, 2025 18:57
@rgsl888prabhu rgsl888prabhu requested a review from gforsyth July 25, 2025 19:02
Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bearing with me during the various iterations @rgsl888prabhu !

@rgsl888prabhu
Copy link
Collaborator Author

Thanks for bearing with me during the various iterations @rgsl888prabhu !

Thanks to you and @jameslamb it is in much better shape.

@rgsl888prabhu
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit 180116c into NVIDIA:branch-25.08 Jul 25, 2025
278 of 286 checks passed
aliceb-nv pushed a commit that referenced this pull request Jul 28, 2025
Adds workflow for container build, test and push for nightly and release.

Nightly container would have the tag for example 25.8.0a-cuda12.8-py3.12

And these will be published to https://hub.docker.com/r/nvidia/cuopt/tags and ngc internal registry.

This PR also removes several unused workflows and also update license header.


## Issue
closes #123

Authors:
  - Ramakrishnap (https://github.com/rgsl888prabhu)

Approvers:
  - Trevor McKay (https://github.com/tmckayus)
  - Gil Forsyth (https://github.com/gforsyth)

URL: #180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA] Add nightly container builder to repo

4 participants