Skip to content

Fix bug in scaling of dual slacks and sign of dual variables for >= constraints #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 1 commit into from
Jul 14, 2025
Merged

Fix bug in scaling of dual slacks and sign of dual variables for >= constraints #191

rapids-bot merged 1 commit into from
Jul 14, 2025

Conversation

@chris-maes
Copy link
Contributor

@chris-maes chris-maes commented Jul 7, 2025 •
edited by rg20
Loading

Description

Fixes a bug in how dual slacks (reduced costs) were unscaled.

Fixes #183 : dual simplex produces the wrong sign for dual variables with >= constraints

Issue

closes #183

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • [] Added new documentation
    • NA

@chris-maes chris-maes requested a review from a team as a code owner July 7, 2025 22:49
@chris-maes chris-maes requested review from aliceb-nv and kaatish July 7, 2025 22:49
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 7, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chris-maes chris-maes self-assigned this Jul 7, 2025
@chris-maes chris-maes added bug Something isn't working non-breaking Introduces a non-breaking change labels Jul 7, 2025
@chris-maes chris-maes added this to the 25.08 milestone Jul 7, 2025
@chris-maes
Copy link
Contributor Author

chris-maes commented Jul 7, 2025

/ok to test 1b2c08a

@rg20
Copy link
Contributor

rg20 commented Jul 14, 2025

/merge

@rapids-bot rapids-bot bot merged commit 3204e5a into branch-25.08 Jul 14, 2025
74 checks passed
@rgsl888prabhu rgsl888prabhu deleted the dual_variable_fixes branch October 29, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rg20 rg20 rg20 approved these changes

@kaatish kaatish Awaiting requested review from kaatish kaatish is a code owner automatically assigned from NVIDIA/cuopt-engine-codeowners

@aliceb-nv aliceb-nv Awaiting requested review from aliceb-nv aliceb-nv is a code owner automatically assigned from NVIDIA/cuopt-engine-codeowners

Assignees

@chris-maes chris-maes

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

25.08

Development

Successfully merging this pull request may close these issues.

[BUG] Dual simplex produces wrong sign for Lagrange multiplers for >= constraints

3 participants

@chris-maes @rg20