Fix logging levels #201
Merged
Fix logging levels #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliceb-nv
approved these changes
Jul 14, 2025
cpp/CMakeLists.txt
Outdated
| set_property( | ||
| CACHE LIBCUOPT_LOGGING_LEVEL PROPERTY STRINGS "TRACE" "DEBUG" "INFO" "WARN" "ERROR" "CRITICAL" | ||
| "OFF" | ||
| CACHE LIBCUOPT_LOGGING_LEVEL PROPERTY STRINGS "OFF" "CRITICAL" "ERROR" "WARN" "INFO" "DEBUG" "TRACE" |
Contributor
There was a problem hiding this comment.
The order of the strings shouldn't matter right? Since this gets translated into a CUOPT_LOG_ACTIVE_LEVEL=RAPIDS_LOGGER_LOG_LEVEL_${LIBCUOPT_LOGGING_LEVEL} definition
Contributor
Author
There was a problem hiding this comment.
you are right, it was the pattern setting in the init_logger. i misinterpreted it. reverted, thank!
Contributor
|
@akifcorduk there is a logging related issue filed (#187). May be worth combining? |
Contributor
Author
|
@rg20 I commented on the issue. I think it will require a larger change to do that. |
rgsl888prabhu
approved these changes
Jul 15, 2025
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue of formatting when writing to a log file, it was always writing with the default format regardless of the log level. Whereas, for builds on debug and higher levels we want timestamps.