Skip to content

Conversation

@rgsl888prabhu
Copy link
Collaborator

Description

The PR adds

  • end-of-file-fixer - expects a new line at the end of the file
  • trailing-whitespace - removes trailing white spaces
  • check-builtin-literals
  • check-executables-have-shebangs
  • check-json
  • check-yaml

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@rgsl888prabhu rgsl888prabhu requested review from a team as code owners July 16, 2025 16:19
@rgsl888prabhu rgsl888prabhu requested review from Iroy30, akifcorduk, hlinsen, jameslamb and msarahan and removed request for msarahan July 16, 2025 16:19
@rgsl888prabhu rgsl888prabhu added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change labels Jul 16, 2025
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for doing it! I think you'll be glad you have this, and it should reduce the amount of annoying PR review comments about newlines, trailing space, etc. 😁

Left some very small suggestions, but approving... I don't need to review again.

rgsl888prabhu and others added 2 commits July 16, 2025 13:39
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>
@rgsl888prabhu
Copy link
Collaborator Author

This is great, thanks for doing it! I think you'll be glad you have this, and it should reduce the amount of annoying PR review comments about newlines, trailing space, etc. 😁

Left some very small suggestions, but approving... I don't need to review again.

Thank you @jameslamb

Copy link
Member

@Iroy30 Iroy30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rgsl888prabhu
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit 8818bc7 into NVIDIA:branch-25.08 Jul 17, 2025
141 of 142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants