-
Notifications
You must be signed in to change notification settings - Fork 112
Adding few more pre-commit checks to ensure coding standards #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding few more pre-commit checks to ensure coding standards #213
Conversation
jameslamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks for doing it! I think you'll be glad you have this, and it should reduce the amount of annoying PR review comments about newlines, trailing space, etc. 😁
Left some very small suggestions, but approving... I don't need to review again.
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Thank you @jameslamb |
Iroy30
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
/merge |
Description
The PR adds
Checklist