Skip to content

Conversation

@rg20
Copy link
Contributor

@rg20 rg20 commented May 20, 2025

This PR adds two things:

  1. Introduces a time limit for computing related variables. This function can take a lot of time for very large problems (in this case 20+ M variables). Ideally, we need to speed up this with a better algo and fine tune for larger problems
  2. Catch std::bad_alloc exceptions in solve function. Currently, we only catch cuopt::logic_error

@rg20 rg20 requested a review from a team as a code owner May 20, 2025 19:25
@rg20 rg20 requested review from chris-maes and hlinsen May 20, 2025 19:25
@copy-pr-bot
Copy link

copy-pr-bot bot commented May 20, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rg20 rg20 added the bug Something isn't working label May 20, 2025
@rg20 rg20 added this to the 25.05 milestone May 20, 2025
@rg20 rg20 added the non-breaking Introduces a non-breaking change label May 20, 2025
@rg20 rg20 force-pushed the mip_timelimit_ootm branch from 3c271c5 to ab8d9d7 Compare May 20, 2025 19:30
@rg20
Copy link
Contributor Author

rg20 commented May 20, 2025

/ok to test ab8d9d7

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should a bad_alloc be a cuopt::logic_error? We might want to create a different cuopt exception for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad_alloc is thrown by rmm, unless we catch them somewhere and convert them to logic_error, which is what I am doing here

@rg20
Copy link
Contributor Author

rg20 commented May 21, 2025

/ok to test 98411dd

@rg20
Copy link
Contributor Author

rg20 commented May 21, 2025

/merge

@rapids-bot rapids-bot bot merged commit 0a04b79 into NVIDIA:branch-25.05 May 21, 2025
82 checks passed
@rg20 rg20 deleted the mip_timelimit_ootm branch May 22, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants