-
Notifications
You must be signed in to change notification settings - Fork 108
Handle out of memory and out of time limit issues gracefully #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ception in C++ layer
|
/ok to test ab8d9d7 |
cpp/src/linear_programming/solve.cu
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should a bad_alloc be a cuopt::logic_error? We might want to create a different cuopt exception for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad_alloc is thrown by rmm, unless we catch them somewhere and convert them to logic_error, which is what I am doing here
|
/ok to test 98411dd |
|
/merge |
This PR adds two things:
std::bad_allocexceptions in solve function. Currently, we only catchcuopt::logic_error