No cuda graph in batched pdlp #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kh4ster
requested review from
akifcorduk,
hlinsen and
kaatish
and removed request for
hlinsen and
kaatish
akifcorduk
approved these changes
Jul 23, 2025
Contributor
akifcorduk
left a comment
akifcorduk
left a comment
There was a problem hiding this comment.
Thanks Nicolas! Could you enable the python tests again? (and cpp if there are any)
Kh4ster
added
bug
tmckayus
approved these changes
Jul 23, 2025
Collaborator
@Kh4ster PLease create an issue or tag the issue for the follow-up. |
Contributor
Author
|
@rgsl888prabhu done! |
Collaborator
@Kh4ster I meant a follow-up issue to enable cuda graph back with the root cause fix. |
Contributor
Author
|
/merge |
aliceb-nv
pushed a commit
that referenced
this pull request
Sep 22, 2025
Temporarly disable cuda graph in batched PDLP until we find the root cause. This allows use to re-enable the tests on the Python side Closes #207 Authors: - Nicolas Blin (https://github.com/Kh4ster) Approvers: - Akif ÇÖRDÜK (https://github.com/akifcorduk) - Trevor McKay (https://github.com/tmckayus) URL: #225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarly disable cuda graph in batched PDLP until we find the root cause.
This allows use to re-enable the tests on the Python side
Closes #207