Unset NDEBUG in cmake in assert mode #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlinsen
added
bug
rgsl888prabhu
approved these changes
Jul 29, 2025
Contributor
|
I pushed a fix for the failing cpp tests |
Contributor
Author
Thanks Alice! |
Collaborator
|
@akifcorduk @aliceb-nv may I get your review on this PR ? |
aliceb-nv
approved these changes
Jul 30, 2025
Contributor
aliceb-nv
left a comment
aliceb-nv
left a comment
There was a problem hiding this comment.
Very good catch with this PR Hugo, thanks! That will help us be much more confident about our robustness :)
Collaborator
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raft defines
RAFT_CHECK_CUDAdepending on if we run in release/Debug mode https://github.com/rapidsai/raft/blob/branch-25.06/cpp/include/raft/util/cuda_rt_essentials.hpp#L78-L82.In cuopt we have a special mode "assert" that undefines
NDEBUGto run with optimizations but still enable runtime checks. https://github.com/rapidsai/raft/blob/branch-25.06/cpp/include/raft/util/cuda_rt_essentials.hpp#L78-L82The first version of
RAFT_CHECK_CUDAuses the stream argument therefore in debug mode and assert mode we should catch that error. However unsettingNDEBUGin our header results inNDEBUGbeing undefined in cuopt but still defined for our dependencies. So we were calling the wrong implementation ofRAFT_CUDA_CHECK. To undefineNDEBUGin both cuopt and our dependencies we have to do it through cmake.This catches the compile error.
Closes: #247