Fix bug in C API for bool parameters. Fix bug on irish-electricty #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also log when we change settings. And don't print the log headers.
chris-maes
added
bug
Contributor
Author
|
/ok to test 37cdeb2 |
rg20
reviewed
May 21, 2025
rg20
reviewed
May 21, 2025
Contributor
Author
|
/ok to test @d0bde3e |
tmckayus
approved these changes
May 21, 2025
rg20
reviewed
May 21, 2025
Contributor
Author
|
/ok to test 1c70bc0 |
rg20
approved these changes
May 21, 2025
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since C does not have a boolean type, we need to allow
cuOptGetIntParameterandcuOptSetIntParameterto work for boolean parameters as well.On irish-electricity we had a bug where we were stopping PDLP early, due to a numerical error inside dual simplex. In concurrent mode we should only stop the other solver when we have reached a definitive conclusion on the problem.
Fix a bug in the Python docstrings found by Flora.
Also log whenever we change settings. And set the log pattern to
%voutside the solve as well.