-
Notifications
You must be signed in to change notification settings - Fork 111
Adding actions to automate auto issue assignment and reminder on inactivity #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding actions to automate auto issue assignment and reminder on inactivity #268
Conversation
tmckayus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, as long as we remember that assignee in this setup is the PIC and not necessarily the one doing the implementation.
Agree, this is just to notify one of us so we can ping an appropriate group for more help. |
|
@jameslamb may I get your review on this PR |
jameslamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it were up to me, I would not introduce this round_robin_assign bot at all, and I would make the inactivity_reminder bot much less verbose.
I put some specific ideas about that in comments on this PR, and added some other ideas in #255 (comment) on how you could solve the project management problems you're facing without new bots.
One other minor point here... these new workflows will eat into this repo's GitHub API rate limits. That will increase the risk of builds failing because they cannot upload / download artifacts, for example. I don't think it will be too much of a worry at this repo's current activity levels, but another argument in favor of trimming this down.
If you experience problems like that, please note that the RAPIDS CI workflows you're using have a "Check GitHub API Rate Limits" step that you can use to see your usage:
https://github.com/NVIDIA/cuopt/actions/runs/16983366956/job/48147813721#step:11:28
Despite my concerns about this, I'm going to mark this "Approve". You all can handle prioritization, project management, and communication with your users/contributors in whatever way you decide. The implementation looks ok to me and I don't think it'd affect security, performance, correctness, etc. here.
But please do consider some of my suggestions.
|
|
||
| on: | ||
| schedule: | ||
| - cron: '0 9 * * *' # Runs daily at 09:00 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be helpful to add workflow_dispatch: for these workflows, so you can test changes by manually triggering them from the GitHub UI.
That'd only work if you opened the PR from a cuopt branch (not your fork), though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let me test this out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameslamb tested it and behavior is noted in the description #268 (comment)
…_public into add_actions_automate
|
/merge |
Description
Adding actions to automate auto issue assignment and reminder on inactivity.
Issues
PR
This way we not get pinged for all back-logged issues and only pings any important and recent ones which we deemed good.
example issue - #309 (comment)
example PR - #310 (comment)
If there is no asignee, by default it will ping @anandhkb on all issues and PRs
Issue
closes #255
Checklist