Skip to content

Conversation

@rgsl888prabhu
Copy link
Collaborator

@rgsl888prabhu rgsl888prabhu commented Aug 8, 2025

Description

Adding actions to automate auto issue assignment and reminder on inactivity.

Issues

  • Issue with "awaiting response" label are the only ones which will be tracked/notified
  • If this is removed, then this will not be tracked
  • Another option is also to use label "skip inactivity reminder"

PR

  • All the PR will get notified which are open
  • If it is a draft PR, it will not be notified
  • Same label can be used here if you want to disable the notifier

This way we not get pinged for all back-logged issues and only pings any important and recent ones which we deemed good.

example issue - #309 (comment)
example PR - #310 (comment)

If there is no asignee, by default it will ping @anandhkb on all issues and PRs

image image

Issue

closes #255

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@rgsl888prabhu rgsl888prabhu self-assigned this Aug 8, 2025
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner August 8, 2025 20:00
@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Aug 8, 2025
@rgsl888prabhu rgsl888prabhu requested a review from jakirkham August 8, 2025 20:00
@rgsl888prabhu rgsl888prabhu requested review from jameslamb and removed request for jakirkham August 8, 2025 20:01
Copy link
Contributor

@tmckayus tmckayus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, as long as we remember that assignee in this setup is the PIC and not necessarily the one doing the implementation.

@anandhkb anandhkb added this to the 25.10 milestone Aug 11, 2025
@rgsl888prabhu
Copy link
Collaborator Author

This looks good to me, as long as we remember that assignee in this setup is the PIC and not necessarily the one doing the implementation.

Agree, this is just to notify one of us so we can ping an appropriate group for more help.

@rgsl888prabhu
Copy link
Collaborator Author

@jameslamb may I get your review on this PR

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it were up to me, I would not introduce this round_robin_assign bot at all, and I would make the inactivity_reminder bot much less verbose.

I put some specific ideas about that in comments on this PR, and added some other ideas in #255 (comment) on how you could solve the project management problems you're facing without new bots.

One other minor point here... these new workflows will eat into this repo's GitHub API rate limits. That will increase the risk of builds failing because they cannot upload / download artifacts, for example. I don't think it will be too much of a worry at this repo's current activity levels, but another argument in favor of trimming this down.

If you experience problems like that, please note that the RAPIDS CI workflows you're using have a "Check GitHub API Rate Limits" step that you can use to see your usage:

image

https://github.com/NVIDIA/cuopt/actions/runs/16983366956/job/48147813721#step:11:28


Despite my concerns about this, I'm going to mark this "Approve". You all can handle prioritization, project management, and communication with your users/contributors in whatever way you decide. The implementation looks ok to me and I don't think it'd affect security, performance, correctness, etc. here.

But please do consider some of my suggestions.


on:
schedule:
- cron: '0 9 * * *' # Runs daily at 09:00 UTC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be helpful to add workflow_dispatch: for these workflows, so you can test changes by manually triggering them from the GitHub UI.

That'd only work if you opened the PR from a cuopt branch (not your fork), though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let me test this out.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jameslamb tested it and behavior is noted in the description #268 (comment)

@rgsl888prabhu rgsl888prabhu changed the base branch from branch-25.10 to branch-25.08 August 18, 2025 13:04
@rgsl888prabhu rgsl888prabhu changed the base branch from branch-25.08 to branch-25.10 August 18, 2025 13:05
@rgsl888prabhu rgsl888prabhu removed the request for review from a team August 18, 2025 13:05
@rgsl888prabhu
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit b567ed4 into NVIDIA:branch-25.10 Aug 19, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA] Add automation to trigger add PICs to new issues to follow and trigger notifications for old issues and PRs.

4 participants