Skip to content

Conversation

@chris-maes
Copy link
Contributor

Dual simplex presolve had an assert to prevent it from removing an empty column with a variable with an infinite bounds.

This PR removes the assert and just skips variables with infinite bounds.

This fixes Issue #270

@chris-maes chris-maes requested a review from a team as a code owner August 11, 2025 18:28
@chris-maes chris-maes requested review from kaatish and rg20 August 11, 2025 18:28
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 11, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chris-maes chris-maes self-assigned this Aug 11, 2025
@chris-maes chris-maes added bug Something isn't working non-breaking Introduces a non-breaking change labels Aug 11, 2025
@chris-maes chris-maes added this to the 25.10 milestone Aug 11, 2025
@chris-maes
Copy link
Contributor Author

/ok to test 0c0cf43

Copy link
Contributor

@akifcorduk akifcorduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris! Do you think it could be related to the bug that submip has on refactorization ?

@chris-maes
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 148c04c into NVIDIA:branch-25.10 Aug 12, 2025
107 of 110 checks passed
@chris-maes chris-maes deleted the presolve_empty_cols branch August 12, 2025 15:09
@chris-maes
Copy link
Contributor Author

Thanks Chris! Do you think it could be related to the bug that submip has on refactorization ?

@akifcorduk perhaps, if you have empty columns in the submip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants