-
Notifications
You must be signed in to change notification settings - Fork 111
Bug fix: solution incorrect when simplex presolve removes empty columns #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 4 commits into
NVIDIA:branch-25.05
from
chris-maes:fix_presolve_removed_empty_cols
May 23, 2025
Merged
Bug fix: solution incorrect when simplex presolve removes empty columns #29
rapids-bot
merged 4 commits into
NVIDIA:branch-25.05
from
chris-maes:fix_presolve_removed_empty_cols
May 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/ok to test f622513 |
rg20
reviewed
May 22, 2025
Contributor
Author
|
/ok to test 769771f |
rg20
approved these changes
May 22, 2025
Contributor
Author
|
/ok to test f7d243e |
Contributor
Author
|
/ok to test de78eb6 |
Kh4ster
approved these changes
May 23, 2025
Contributor
Kh4ster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Contributor
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported on the following MPS file, where
_dummyvariable does not appear in the constraints. We remove empty columns (and thus_dummy) in presolve for dual simplex. But do not take this into account when constructing the solution.Further work, is needed to develop an actual LP presolve.
Fixes #13 which was caused by an issue in column scaling when the norm of a column is zero.