Skip to content

Conversation

@chris-maes
Copy link
Contributor

@chris-maes chris-maes commented May 22, 2025

Fixes an issue reported on the following MPS file, where _dummy variable does not appear in the constraints. We remove empty columns (and thus _dummy) in presolve for dual simplex. But do not take this into account when constructing the solution.

Further work, is needed to develop an actual LP presolve.

*SENSE:Minimize
NAME          test_export_dict_LP_no_obj
ROWS
 N  OBJ
 G  c1
 E  c2
 L  c3
 G  c4
COLUMNS
    __dummy   OBJ        1.000000000000e+00
    w         c4         1.000000000000e+00
    x         c1         1.000000000000e+00
    x         c2         1.000000000000e+00
    y         c1         1.000000000000e+00
    y         c3        -1.000000000000e+00
    z         c2         1.000000000000e+00
    z         c3         1.000000000000e+00
RHS
    RHS       c1         5.000000000000e+00
    RHS       c2         1.000000000000e+01
    RHS       c3         7.000000000000e+00
    RHS       c4         0.000000000000e+00
BOUNDS
 FX BND       __dummy    0.000000000000e+00
 FX BND       w          0.000000000000e+00
 UP BND       x          4.000000000000e+00
 LO BND       y         -1.000000000000e+00
 UP BND       y          1.000000000000e+00

Fixes #13 which was caused by an issue in column scaling when the norm of a column is zero.

@chris-maes chris-maes requested a review from a team as a code owner May 22, 2025 17:37
@chris-maes chris-maes requested review from Kh4ster and kaatish May 22, 2025 17:37
@copy-pr-bot
Copy link

copy-pr-bot bot commented May 22, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chris-maes chris-maes self-assigned this May 22, 2025
@chris-maes chris-maes added bug Something isn't working non-breaking Introduces a non-breaking change labels May 22, 2025
@chris-maes chris-maes added this to the 25.05 milestone May 22, 2025
@chris-maes
Copy link
Contributor Author

/ok to test f622513

@chris-maes
Copy link
Contributor Author

/ok to test 769771f

@chris-maes
Copy link
Contributor Author

/ok to test f7d243e

@chris-maes
Copy link
Contributor Author

/ok to test de78eb6

Copy link
Contributor

@Kh4ster Kh4ster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@akifcorduk
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 8eff792 into NVIDIA:branch-25.05 May 23, 2025
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] standgub.json from netlib/lp fails if zero-only final column is left in the constraint matrix

4 participants