Skip to content

Changes to download lp and milp dataset and also disable cvxpy testing for 3.10 #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 2 commits into from
Aug 18, 2025
Merged

Changes to download lp and milp dataset and also disable cvxpy testing for 3.10 #317

rapids-bot merged 2 commits into from
Aug 18, 2025

Conversation

@rgsl888prabhu
Copy link
Collaborator

@rgsl888prabhu rgsl888prabhu commented Aug 18, 2025 •
edited
Loading

Description

Trying to avoid failure due to cert issues.

Disabling testing for CVXPY for python 3.10 since cvxpy dropped support for 3.10.

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@rgsl888prabhu rgsl888prabhu added this to the 25.10 milestone Aug 18, 2025
@rgsl888prabhu rgsl888prabhu self-assigned this Aug 18, 2025
@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Aug 18, 2025
@rgsl888prabhu rgsl888prabhu mentioned this pull request Aug 18, 2025
Closed
@rgsl888prabhu rgsl888prabhu changed the title Changes to download lp and milp dataset download Changes to download lp and milp dataset Aug 18, 2025
chris-maes
chris-maes approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@chris-maes chris-maes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing.

@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner August 18, 2025 19:30
@rgsl888prabhu rgsl888prabhu changed the title Changes to download lp and milp dataset Changes to download lp and milp dataset and also disable cvxpy testing for 3.10 Aug 18, 2025
@rgsl888prabhu
Copy link
Collaborator Author

rgsl888prabhu commented Aug 18, 2025

/merge

@rapids-bot rapids-bot bot merged commit a1aeed8 into NVIDIA:branch-25.10 Aug 18, 2025
143 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmckayus tmckayus tmckayus approved these changes

@Iroy30 Iroy30 Iroy30 approved these changes

@chris-maes chris-maes chris-maes approved these changes

Assignees

@rgsl888prabhu rgsl888prabhu

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

25.10

Development

Successfully merging this pull request may close these issues.

4 participants

@rgsl888prabhu @tmckayus @Iroy30 @chris-maes