Skip to content

Conversation

@rg20
Copy link
Contributor

@rg20 rg20 commented Aug 19, 2025

Description

On the LP benchmark tests, while PDLP and dual simplex stop at a feasible solution, the post solve fails because of infeasibility. This is because of the way the tolerances are handled.

  • The presolver uses absolute criteria while the LP solver uses relative criteria. Now, we turn off the absolute criteria for LP problems keep it only for MIP and IP problems
  • The default tolerance in the presolver is 1e-6, now we pass the tolerance used by the solver to presolver

Issue

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • [] NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@rg20 rg20 requested a review from a team as a code owner August 19, 2025 17:42
@rg20 rg20 requested review from akifcorduk and aliceb-nv August 19, 2025 17:42
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 19, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rg20 rg20 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change P0 labels Aug 19, 2025
@rg20 rg20 added this to the 25.10 milestone Aug 19, 2025
@rg20
Copy link
Contributor Author

rg20 commented Aug 19, 2025

/ok to test 24a3653

@rg20
Copy link
Contributor Author

rg20 commented Aug 20, 2025

/ok to test f76da6f

@rg20
Copy link
Contributor Author

rg20 commented Aug 20, 2025

/merge

@rapids-bot rapids-bot bot merged commit fdb5fbd into NVIDIA:branch-25.10 Aug 20, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change P0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants