-
Notifications
You must be signed in to change notification settings - Fork 108
Adding support nightly cuopt-examples notebook testing #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support nightly cuopt-examples notebook testing #342
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test ce40ff8 |
|
/ok to test ce40ff8 |
|
/ok to test 5d04191 |
|
/ok to test 7968bab |
|
/ok to test 7cf79c0 |
1 similar comment
|
/ok to test 7cf79c0 |
|
/ok to test 43e6418 |
|
/ok to test 891408f |
|
/ok to test 65eac17 |
|
/ok to test bba7a04 |
|
@jameslamb may I get your review on this PR |
jameslamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me! I checked the logs (build link) and appreciate how informative they are, especially around the cleaning of ! commands which is the place where I think this is most likely to fail.
I think it's fine that the examples are coming from another repo since that repo is also in the NVIDIA org and controlled by similar security restrictions, branch protections, review standards, etc.
But you might in the future consider pinning to a specific commit of that repo instead of a branch ... otherwise, merges there could block all PR CI here.
And exciting that you were able to remove a bunch of unnecessary dependencies here!
Yeah, I am planning to keep it only for nightly and remove it from PR for exact same reasons that I don't want to block PRs. |
…uopt_public into nightly_notebook_support
|
/merge |
This adds testing for https://github.com/NVIDIA/cuopt-examples to nightly testing suite. ## Issue closes #334 closes #212 Authors: - Ramakrishnap (https://github.com/rgsl888prabhu) Approvers: - James Lamb (https://github.com/jameslamb) - Trevor McKay (https://github.com/tmckayus) URL: #342
Description
This adds testing for https://github.com/NVIDIA/cuopt-examples to nightly testing suite.
Issue
closes #334
closes #212
Checklist