Skip to content

Conversation

@ahehn-nv
Copy link
Contributor

Description

Adding zlib and bzip2 decompression to mps_parser, such that .mps.gz and .mps.bz2 files can be opened directly.

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 28, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>
@anandhkb anandhkb added this to the 25.10 milestone Aug 28, 2025
@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Aug 28, 2025
@rgsl888prabhu
Copy link
Collaborator

/ok to test 0672b41

@rgsl888prabhu
Copy link
Collaborator

/ok to test 4cc3a6c

@rgsl888prabhu
Copy link
Collaborator

/ok to test 6d54acf

@rgsl888prabhu
Copy link
Collaborator

/ok to test d050010

@rgsl888prabhu
Copy link
Collaborator

/ok to test 50abd29

@rgsl888prabhu
Copy link
Collaborator

/ok to test 823b28f

Copy link
Contributor

@Kh4ster Kh4ster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super useful addition and great code quality, many thanks!

Copy link
Contributor

@aliceb-nv aliceb-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approving :)

@aliceb-nv
Copy link
Contributor

/ok to test 01f133b

Copy link
Member

@Iroy30 Iroy30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgsl888prabhu
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 536488d into NVIDIA:branch-25.10 Sep 3, 2025
73 checks passed
@ahehn-nv ahehn-nv deleted the ahehn/libmps_parser_compression branch September 8, 2025 11:45
aliceb-nv pushed a commit that referenced this pull request Sep 22, 2025
Adding zlib and bzip2 decompression to mps_parser, such that .mps.gz and .mps.bz2 files can be opened directly.

Authors:
  - https://github.com/ahehn-nv
  - Ramakrishnap (https://github.com/rgsl888prabhu)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Nicolas Blin (https://github.com/Kh4ster)
  - Alice Boucher (https://github.com/aliceb-nv)
  - Ishika Roy (https://github.com/Iroy30)

URL: #357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants