Fix bug on probing cache usage of lb bounds prop and probing cache bounds lookup with wrong variable id #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nning kernels in other places too
…ion multiple times
… B&B solution not directly added
…probing cache compraing to the host bounds using original ids
chris-maes
approved these changes
May 24, 2025
Contributor
chris-maes
left a comment
chris-maes
left a comment
There was a problem hiding this comment.
LGTM but I'm not an expert on this code.
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we fixed the bug of fixed problems using wrong probing cache ids by having an origial variable id map. However, after the merge of load balanced versions, the fix was ommited in the load balanced versions.
There was a related probing cache lookup bug in which we were using the fixed original problems variables ids with the fixed problems host bounds. Now this is solved by keeping a reverse map too.