Skip to content

Conversation

@rgsl888prabhu
Copy link
Collaborator

@rgsl888prabhu rgsl888prabhu commented Sep 15, 2025

Description

This PR adds jump testing to take advantage of several unit tests to bolster test suite

Issue

closes #380

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner September 15, 2025 18:56
@rgsl888prabhu rgsl888prabhu self-assigned this Sep 15, 2025
@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Sep 15, 2025
@rgsl888prabhu rgsl888prabhu changed the title [DRAFT] Add jump testing to nightly testing Add jump testing to nightly testing Sep 24, 2025
@rg20
Copy link
Contributor

rg20 commented Sep 25, 2025

What's the overhead of running the jump tests in CI?

@rgsl888prabhu
Copy link
Collaborator Author

rgsl888prabhu commented Sep 25, 2025

What's the overhead of running the jump tests in CI?

  • One issue would be any breakage in JUMP would halt other PRs from getting merged, the ones we saw recently with not able to handle nothing/None while setting "settings".
  • And this also adds ~10-15 mins additional time for each cuopt wheel testing, which increases from 20-22 min runs to 33-38 mins.

@rgsl888prabhu
Copy link
Collaborator Author

What's the overhead of running the jump tests in CI?

  • One issue would be any breakage in JUMP would halt other PRs from getting merged, the ones we saw recently with not able to handle nothing/None while setting "settings".
  • And this also adds ~10-15 mins additional time for each cuopt wheel testing, which increases from 20-22 min runs to 33-38 mins.

But this can also act as one more point of check with Jump.

@rgsl888prabhu
Copy link
Collaborator Author

@gforsyth May I get your review on this PR ?

Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@rgsl888prabhu
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit a722e93 into NVIDIA:branch-25.10 Sep 26, 2025
143 of 146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA] Add jump testing to nightly for exhaustive testing

4 participants