-
Notifications
You must be signed in to change notification settings - Fork 112
avoid triggering nightly tests until builds are complete #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
…ightly-tests-after-builds
|
If you still see the issue in doc, can you please update the link to https://docs.nvidia.com/ngc/latest/ngc-private-registry-user-guide.html#generating-a-personal-api-key |
|
Ok yep will do! And I think this new error:
Is a result of rapidsai/rmm#2036 It should be fixed by other RAPIDS packages being rebuilt, which @bdice triggered here: https://github.com/rapidsai/workflows/actions/runs/17949845053 |
Looks like that was not enough, probably for the reasons being discussed in rapidsai/build-planning#218 This should hopefully be resolved later today when the RAPIDS Ops team deletes some nightly packages to allow new ones to be published. |
This did fail again 😭 https://github.com/NVIDIA/cuopt/actions/runs/17962030366/job/51090641582?pr=408 Updated those links in the way you suggested: 386dad2 |
|
/merge |
Description
Replaces #359 (my more-complicated earlier attempt at this)
This project runs nightly builds and tests on a cron schedule:
cuopt/.github/workflows/nightly.yaml
Lines 1 to 6 in 36a6a1c
Tests need to wait for builds to finish, and that's currently done with some shell scripts that hit the GitHub API, using a mix of
sleepand polling.This has sometimes resulted in nightly failures (network errors, timeouts, etc.). This PR proposes reducing the risk of such failures by moving that logic into GitHub Actions configuration directly, specifically:
build.yamltriggertest.yamlwith the GitHub CLI only after all package builds and publishing have finishedIssue
Contributes to #122
Notes for Reviewers
How I tested this
I manually triggered this run of the "Trigger Nightly cuOpt Pipeline": https://github.com/NVIDIA/cuopt/actions/runs/17935159871
Which triggered this
buildrun: https://github.com/NVIDIA/cuopt/actions/runs/17935161536Which triggered this
testrun: https://github.com/NVIDIA/cuopt/actions/runs/17936474025Things look ok to me!
The
testrun was triggered until after all the relevant package builds and uploads were done, and BEFORE the docker image builds were done (as intended, to not be delayed waiting on them).There are some test failures from artifact-downloading, like this:
But I think they'll be fixed by merging #409
And the naming changes for the image builds look good 😁