Compute relative gap with respect to user objectives #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rg20
added
bug
rg20
requested review from
chris-maes and
nguidotti
and removed request for
chris-maes and
hlinsen
Contributor
Author
|
/ok to test |
@rg20, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Contributor
Author
|
/ok to test 40f19a2 |
aliceb-nv
approved these changes
Sep 25, 2025
Contributor
aliceb-nv
left a comment
aliceb-nv
left a comment
There was a problem hiding this comment.
Thanks for the super quick fix Rajesh!
Contributor
|
/ok to test 40f19a2 |
Contributor
Author
|
/ok to test d42c7b8 |
Contributor
Author
|
/ok to test d5edb2e |
Contributor
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In branch-and-bound, to stop the search, we are currently computing the relative gap based on the working problem. When the objective offset is very large, the relative gap on the user problem can be very large even when it is small on the working problem. This PR fixes this by always computing the relative gap with respect to the user problem.
Issue
Closes #417
Checklist