Fix variables out of bounds caused by CPUFJ LP scratch thread #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliceb-nv
added
bug
nguidotti
approved these changes
Oct 1, 2025
Contributor
nguidotti
left a comment
nguidotti
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the quick fix, Alice.
rg20
approved these changes
Oct 1, 2025
Contributor
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the CPUFJ LP scratch thread is started before the LP relaxation solution is found (if one is found), the initial solution vector may not satisfy the problem variable bounds. This PR fixes the issue by ensuring the CPUFJ LP thread is started only after such a solution is found. The initial solution is also projected to the variable bounds to ensure no such violation can exist.
Closes #423