Skip to content

Conversation

@aliceb-nv
Copy link
Contributor

This PR fixes an UB situation in GF2 caused by a cast of a negative floating-point value to an unsigned integer, which only manifested on ARM.
Also included is a fix to improve CI success rates on a PDLP python test.
closes #431

@aliceb-nv aliceb-nv added this to the 25.10 milestone Oct 3, 2025
@aliceb-nv aliceb-nv requested a review from a team as a code owner October 3, 2025 10:53
@aliceb-nv aliceb-nv added the bug Something isn't working label Oct 3, 2025
@aliceb-nv aliceb-nv requested a review from a team as a code owner October 3, 2025 10:53
@aliceb-nv aliceb-nv added the non-breaking Introduces a non-breaking change label Oct 3, 2025
@aliceb-nv aliceb-nv requested review from akifcorduk, hlinsen, nguidotti and rgsl888prabhu and removed request for akifcorduk October 3, 2025 10:53
@aliceb-nv
Copy link
Contributor Author

/ok to test 50d6658

Copy link
Contributor

@rg20 rg20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@rg20 rg20 removed request for hlinsen and nguidotti October 3, 2025 14:28
@aliceb-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 3824f96 into branch-25.10 Oct 3, 2025
88 checks passed
@rgsl888prabhu rgsl888prabhu deleted the gf2-bugfix branch October 29, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] GF2 presolve doesn't work on ARM machines

4 participants