Skip to content

Fixed delayed termination after timeout #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
Oct 7, 2025
Merged

Fixed delayed termination after timeout #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions cpp/src/dual_simplex/branch_and_bound.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,7 @@ node_status_t branch_and_bound_t<i_t, f_t>::solve_node(search_tree_t<i_t, f_t>&
lp_settings.set_log(false);
lp_settings.cut_off = upper_bound + settings_.dual_tol;
lp_settings.inside_mip = 2;
lp_settings.time_limit = settings_.time_limit - toc(stats_.start_time);

// in B&B we only have equality constraints, leave it empty for default
std::vector<char> row_sense;
Expand Down Expand Up @@ -739,7 +740,7 @@ void branch_and_bound_t<i_t, f_t>::exploration_ramp_up(search_tree_t<i_t, f_t>*
}
}

if (toc(stats_.start_time) > settings_.time_limit) {
if (now > settings_.time_limit) {
status_ = mip_exploration_status_t::TIME_LIMIT;
return;
}
Expand Down Expand Up @@ -836,17 +837,17 @@ void branch_and_bound_t<i_t, f_t>::explore_subtree(i_t id,
}
}

if (toc(stats_.start_time) > settings_.time_limit) {
if (now > settings_.time_limit) {
status_ = mip_exploration_status_t::TIME_LIMIT;
break;
return;
}

node_status_t node_status =
solve_node(search_tree, node_ptr, leaf_problem, Arow, upper_bound, settings_.log, 'B');

if (node_status == node_status_t::TIME_LIMIT) {
status_ = mip_exploration_status_t::TIME_LIMIT;
break;
return;

} else if (node_status == node_status_t::HAS_CHILDREN) {
// The stack should only contain the children of the current parent.
Expand Down Expand Up @@ -972,11 +973,13 @@ void branch_and_bound_t<i_t, f_t>::diving_thread(lp_problem_t<i_t, f_t>& leaf_pr
continue;
}

if (toc(stats_.start_time) > settings_.time_limit) { return; }

node_status_t node_status =
solve_node(subtree, node_ptr, leaf_problem, Arow, upper_bound, log, 'D');

if (node_status == node_status_t::TIME_LIMIT) {
break;
return;

} else if (node_status == node_status_t::HAS_CHILDREN) {
auto [first, second] = child_selection(node_ptr);
Expand Down