Barrier post-solve, find_dense_columns fix, folding fix #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-maes
added
bug
Contributor
Author
|
/ok to test eb140d1 |
rg20
approved these changes
Oct 7, 2025
chris-maes
changed the title
Contributor
Author
|
/ok to test 08cbac2 |
chris-maes
changed the title
chris-maes
changed the title
Contributor
Author
|
/ok to test e2449a9 |
Contributor
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash on physciansched6-2 in barrier post-solve.
Fixes a crash on roi5alpha10n8 in
find_dense_columns. There was an undefined memory access because the number of nonzeros in the row was greater than the number of rows. This fix correctly sets the size of the array to the number of columns.Fixes an undefined memory reference on roi5alpha10n8 in folding. The colors array was being realloced an so the reference to the refining color pointed to memory that had been freed. This fix gets a new reference to the refining color on each iteration of the loop that splits colors.