Fix an UMA on ns1952667 due to ignoring rank in factorize_basis when no singletons present #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-maes
added
bug
Contributor
Author
|
/ok to test 1792314 |
hlinsen
approved these changes
Oct 8, 2025
| for (i_t p = col_start; p < col_end; ++p) { | ||
| const i_t i = this->i[p]; | ||
| if (row_marker[i] == j) { printf("CSC error: repeated row index %d in column %d\n", i, j); } | ||
| if (i < 0 || i >= this->m) { printf("CSC error: row index %d not in range [0, %d]\n", i, this->m-1); } |
Contributor
There was a problem hiding this comment.
We should probably use cuopt_assert for these checks
Contributor
Author
|
/ok to test 40200ea |
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a basis had no singletons we were incorrectly setting the rank to m, even if the right-looking LU reported that the basis was rank deficient. This caused the column pointers and row indices in the L factor to be invalid. (Since the L factor itself was invalid).
We now correctly handle rank deficiency in the basis when there are no singletons.