Skip to content

Conversation

@chris-maes
Copy link
Contributor

Minor tweaks to the barrier log.

@chris-maes chris-maes requested a review from a team as a code owner October 9, 2025 22:45
@chris-maes chris-maes requested review from Kh4ster and kaatish October 9, 2025 22:45
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 9, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chris-maes chris-maes added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Oct 9, 2025
@chris-maes chris-maes added this to the 25.10 milestone Oct 9, 2025
@chris-maes
Copy link
Contributor Author

/ok to test dda0c5a


if (first_factor) {
settings_.log.printf("Factor time %.2fs\n", numeric_time);
settings_.log.debug("Factorization time : %.2fs\n", numeric_time);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the same indentation as Symbolic factorization time

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it is intended

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is ok, because it is in debug mode.

@chris-maes
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e9a4f81 into NVIDIA:branch-25.10 Oct 10, 2025
171 of 174 checks passed
@chris-maes chris-maes deleted the barrier_log_fixes branch October 10, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants