Skip to content

Fix return on size mismatch in Barrier #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
Oct 14, 2025
Merged

Fix return on size mismatch in Barrier #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cpp/src/dual_simplex/sparse_cholesky.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ class sparse_cholesky_cudss_t : public sparse_cholesky_base_t<i_t, f_t> {
auto d_nnz = Arow.row_start.element(Arow.m, Arow.row_start.stream());
if (nnz != d_nnz) {
settings_.log.printf("Error: nnz %d != A_in.col_start[A_in.n] %d\n", nnz, d_nnz);
exit(1);
return -1;
}

CUDSS_CALL_AND_CHECK(
Expand Down Expand Up @@ -568,7 +568,7 @@ class sparse_cholesky_cudss_t : public sparse_cholesky_base_t<i_t, f_t> {
#endif
if (A_in.n != n) {
printf("Analyze input does not match size %d != %d\n", A_in.n, n);
Copy link
Contributor

@chris-maes chris-maes Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should do settings.log.printf("Analyze ..") here? So it goes to the log.

exit(1);
return -1;
}

nnz = A_in.col_start[A_in.n];
Expand Down Expand Up @@ -669,7 +669,7 @@ class sparse_cholesky_cudss_t : public sparse_cholesky_base_t<i_t, f_t> {
if (nnz != A_in.col_start[A_in.n]) {
settings_.log.printf(
"Error: nnz %d != A_in.col_start[A_in.n] %d\n", nnz, A_in.col_start[A_in.n]);
exit(1);
return -1;
}

CUDA_CALL_AND_CHECK(
Expand Down Expand Up @@ -741,11 +741,11 @@ class sparse_cholesky_cudss_t : public sparse_cholesky_base_t<i_t, f_t> {
handle_ptr_->get_stream().synchronize();
if (static_cast<i_t>(b.size()) != n) {
settings_.log.printf("Error: b.size() %d != n %d\n", b.size(), n);
exit(1);
return -1;
}
if (static_cast<i_t>(x.size()) != n) {
settings_.log.printf("Error: x.size() %d != n %d\n", x.size(), n);
exit(1);
return -1;
}

CUDSS_CALL_AND_CHECK(
Expand Down