Skip to content

Conversation

@rg20
Copy link
Contributor

@rg20 rg20 commented Oct 14, 2025

Description

We were using a temporary bug fix branch that has bug fixes for cliquemerging presolver. This branch is now merged into develop branch. So we are switching to develop branch now.

Issue

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@rg20 rg20 requested review from a team as code owners October 14, 2025 13:42
@rg20 rg20 requested a review from tmckayus October 14, 2025 13:42
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 14, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rg20 rg20 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 14, 2025
@rg20 rg20 added this to the 25.10 milestone Oct 14, 2025
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR updates the papilo dependency in cuOPT's C++ build configuration to switch from a temporary bug fix branch to the main develop branch. The change modifies cpp/CMakeLists.txt to update the git commit hash from 8f710e33d352bf319d30b9c57e70516222f3f5ca (previously tracking a "cliquemergebug" branch) to 741a2b9c8155b249d6df574d758b4d97d4417520 (now tracking the develop branch as of Oct 12, 2025).

The reason for this change is that the bug fixes for the cliquemerging presolver, which were previously isolated in a separate branch, have now been merged into papilo's develop branch. This represents a natural progression in dependency management - moving from a temporary fix back to the main development stream once fixes are integrated. The updated comments in the CMakeLists.txt file now reflect that cuOPT is tracking the develop branch rather than a specific bug fix branch, maintaining transparency about why the develop branch is used instead of the main branch (due to needed presolvers and settings not yet in main).

Important Files Changed

Changed Files
Filename Score Overview
cpp/CMakeLists.txt 4/5 Updated papilo dependency from bug fix branch to develop branch with new commit hash

Confidence score: 4/5

  • This PR is safe to merge with minimal risk as it's a straightforward dependency update
  • Score reflects the low-risk nature of updating to a develop branch that contains previously tested bug fixes, though not a full 5 due to the inherent risk of tracking a development branch
  • Pay close attention to ensuring the new commit hash contains all previously required functionality from the bug fix branch

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@rg20
Copy link
Contributor Author

rg20 commented Oct 14, 2025

/ok to test 871f4a3

@rgsl888prabhu
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 6d22826 into NVIDIA:branch-25.10 Oct 14, 2025
175 of 176 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants