-
Notifications
You must be signed in to change notification settings - Fork 110
Fix nightly container testing suite #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nightly container testing suite #495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
This PR fixes the nightly container testing suite by addressing command execution issues when running containers as root. The changes modify the Docker test script (ci/docker/test_image.sh) to handle the environment properly after switching container users. Specifically, it adds gcc to apt dependencies for package compilation requirements, switches from direct pip command to python -m pip to ensure pip is accessible through Python's module system, and changes pytest invocations from pytest to python -m pytest for consistent module access. These changes resolve PATH and Python module installation context issues that occur when containers run as root and then switch to different users, ensuring the testing commands are properly available regardless of the user context.
Important Files Changed
Changed Files
| Filename | Score | Overview |
|---|---|---|
| ci/docker/test_image.sh | 5/5 | Fixed container testing by adding gcc dependency and switching to module-based invocation for pip and pytest commands |
Confidence score: 5/5
- This PR is safe to merge with minimal risk as it only addresses command availability issues in container testing
- Score reflects straightforward fixes to well-understood containerization issues with no impact on core functionality
- No files require special attention - the single change is a simple shell script fix for CI infrastructure
1 file reviewed, no comments
|
/merge |
|
/merge |
|
@coderabbitai ignore pre-merge checks |
❌ ErrorFailed to override pre-merge checks. Please try again later. |
|
/merge |
Description
Changing container user to root requires changes to how pip and pytest work, so needed update for this.
closes #494
Issue
closes #494
Checklist