Skip to content

Conversation

@rgsl888prabhu
Copy link
Collaborator

Description

Changing container user to root requires changes to how pip and pytest work, so needed update for this.

closes #494

Issue

closes #494

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner October 14, 2025 15:46
@rgsl888prabhu rgsl888prabhu requested review from AyodeAwe and removed request for a team October 14, 2025 15:46
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR fixes the nightly container testing suite by addressing command execution issues when running containers as root. The changes modify the Docker test script (ci/docker/test_image.sh) to handle the environment properly after switching container users. Specifically, it adds gcc to apt dependencies for package compilation requirements, switches from direct pip command to python -m pip to ensure pip is accessible through Python's module system, and changes pytest invocations from pytest to python -m pytest for consistent module access. These changes resolve PATH and Python module installation context issues that occur when containers run as root and then switch to different users, ensuring the testing commands are properly available regardless of the user context.

Important Files Changed

Changed Files
Filename Score Overview
ci/docker/test_image.sh 5/5 Fixed container testing by adding gcc dependency and switching to module-based invocation for pip and pytest commands

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it only addresses command availability issues in container testing
  • Score reflects straightforward fixes to well-understood containerization issues with no impact on core functionality
  • No files require special attention - the single change is a simple shell script fix for CI infrastructure

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@rgsl888prabhu rgsl888prabhu added bug Something isn't working non-breaking Introduces a non-breaking change labels Oct 14, 2025
@rgsl888prabhu rgsl888prabhu self-assigned this Oct 14, 2025
@rgsl888prabhu
Copy link
Collaborator Author

/merge

@rgsl888prabhu rgsl888prabhu removed the request for review from AyodeAwe October 16, 2025 20:55
@rgsl888prabhu
Copy link
Collaborator Author

/merge

@rgsl888prabhu
Copy link
Collaborator Author

@coderabbitai ignore pre-merge checks

@coderabbitai
Copy link

coderabbitai bot commented Oct 16, 2025

❌ Error

Failed to override pre-merge checks. Please try again later.

@anandhkb anandhkb added this to the 25.12 milestone Oct 17, 2025
@rgsl888prabhu
Copy link
Collaborator Author

/merge

@rgsl888prabhu rgsl888prabhu merged commit 42c1aaf into NVIDIA:branch-25.12 Oct 18, 2025
172 of 174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fix nightly container testing, currently the failure is not getting highlighted

3 participants