stop uploading to downloads.rapids.ai, use rapids-init-pip in wheel CI #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Member
Author
|
/ok to test |
rgsl888prabhu
added
bug
jameslamb
changed the title
35 tasks
rgsl888prabhu
approved these changes
May 30, 2025
Member
Author
|
/merge |
8 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
#50 removed uploads of conda packages / wheels to S3 on `branch-25.08` Unfortunately, some publishing workflows on this branch are using a version of GitHub Actions workflows that expects to be able to download packages from S3, resulting in failures like this: ```text jq: error (at <unknown>): Cannot iterate over null (null) Using Anaconda API: https://api.anaconda.org/ Using "rapidsai-wheels-nightly" as upload username Error: File "./dist/*.whl" does not exist Error: File "./dist/*.whl" does not exist ``` ([build link](https://github.com/NVIDIA/cuopt/actions/runs/15853760492/job/44695835791)) This fixes that, by updating to `branch-25.08` of https://github.com/rapidsai/shared-workflows. ## Notes for Reviewers ### Why just the publishing workflows? All other workflows are already using `branch-25.08`... looks like just this small set was missed (or maybe accidentally overwritten by a bad merge conflict resolution or something). ### Issue N/A # Authors: - James Lamb (https://github.com/jameslamb) - Ramakrishnap (https://github.com/rgsl888prabhu) Approvers: - Ramakrishnap (https://github.com/rgsl888prabhu) - Bradley Dice (https://github.com/bdice) URL: #126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#181
downloads.rapids.ai(these are not used by anything in this repo any more)Contributes to rapidsai/build-planning#178
ci/release/update-version-*.shContributes to rapidsai/build-planning#179
rapids-init-pipnear the beginning of all CI scripts that usepipPIP_CONSTRAINTin scripts, in favor of using the one set up byrapids-pip-initNotes for Reviewers
How I identified changes
Looked for uses of the relevant
gha-toolstools, as well as documentation aboutdownloads.rapids.ai, being on the NVIDIA VPN, using S3, etc. like this:git grep -i -E 's3|upload|downloads\.rapids|vpn'How I tested this
See "How I tested this" on rapidsai/shared-workflows#364
Haven't I seen these changes before?
Yes, some of these changes were made in
rapidsai/cuopt(https://github.com/rapidsai/cuopt/pull/2503) but looks like they were lost when this new repo was created.