Skip to content

Conversation

@rgsl888prabhu
Copy link
Collaborator

Description

A follow-up PR for #507, this PR uses EXCLUDE_FROM_ALL on papilo.

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@rgsl888prabhu rgsl888prabhu requested review from a team as code owners October 21, 2025 19:09
@rgsl888prabhu rgsl888prabhu requested review from bdice and tmckayus and removed request for a team October 21, 2025 19:09
@rgsl888prabhu rgsl888prabhu self-assigned this Oct 21, 2025
@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Oct 21, 2025
@rgsl888prabhu rgsl888prabhu removed the request for review from bdice October 21, 2025 19:09
@coderabbitai
Copy link

coderabbitai bot commented Oct 21, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes adjust how papilo dependencies are handled during wheel packaging and build. A shell script re-enables libpapilo-core.a inclusion, CMakeLists.txt marks papilo to be excluded from default top-level builds, and pyproject.toml removes directory exclusions for papilo cmake artifacts.

Changes

Cohort / File(s) Change Summary
Build wheel configuration
ci/build_wheel_libcuopt.sh, python/libcuopt/pyproject.toml
Commented out libpapilo-core.a exclusion in shell script; removed papilo cmake directory exclusions from wheel packaging configuration
CMake build system
cpp/CMakeLists.txt
Added EXCLUDE_FROM_ALL flag to papilo FetchContent_Declare to prevent default top-level build inclusion

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A wheel now rolls with papilo inside,
Build flags whisper, exclusions subside,
CMake declares what should not build by default,
While dependencies settle, snug in their vault! 🛞

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Remove papilo from getting added to packaging" is clearly related to the changeset's main objective. The pull request implements changes across three files to prevent papilo from being included in the final wheel package: adding EXCLUDE_FROM_ALL to the CMakeLists.txt to prevent papilo from being built during top-level build, commenting out the libpapilo-core.a exclusion in the build script (since it won't be built anyway), and removing papilo-related exclusion entries from pyproject.toml. The title concisely captures this primary goal and is specific enough that a reviewer can understand the main intent.
Description Check ✅ Passed The description "A follow-up PR for #507, this PR uses EXCLUDE_FROM_ALL on papilo" is directly related to the changeset. It provides meaningful context by referencing the related issue for package size reduction and describing the specific implementation approach (EXCLUDE_FROM_ALL), which is the core mechanism underlying all three file changes. The description meaningfully connects to the actual changes being made, even though it is brief.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rgsl888prabhu rgsl888prabhu requested a review from vyasr October 21, 2025 19:09
@rgsl888prabhu
Copy link
Collaborator Author

@CodeRabbit review

@coderabbitai
Copy link

coderabbitai bot commented Oct 21, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix.

@rgsl888prabhu
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit 10f116b into NVIDIA:main Oct 22, 2025
172 of 174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants