-
Notifications
You must be signed in to change notification settings - Fork 111
Remove papilo from getting added to packaging #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove papilo from getting added to packaging #521
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes adjust how papilo dependencies are handled during wheel packaging and build. A shell script re-enables libpapilo-core.a inclusion, CMakeLists.txt marks papilo to be excluded from default top-level builds, and pyproject.toml removes directory exclusions for papilo cmake artifacts. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
vyasr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the fix.
|
/merge |
Description
A follow-up PR for #507, this PR uses EXCLUDE_FROM_ALL on papilo.
Checklist