Skip to content

Handle concurrent mode oom and avoid unnecessary deep copy of problem_t #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 2 commits into from
Oct 27, 2025
Merged

Handle concurrent mode oom and avoid unnecessary deep copy of problem_t #541

rapids-bot merged 2 commits into from
Oct 27, 2025

Conversation

@hlinsen
Copy link
Contributor

@hlinsen hlinsen commented Oct 24, 2025

user_problem_t holds the raft::handle_t for the whole Barrier solver run. Setting the handle correctly and calling run_barrier_thread allows running Barrier in its own stream without deep copying the problem_t.
We are now able to solve large scale instances and any OOM in Barrier is caught and PDLP keeps iterating.

@hlinsen hlinsen requested a review from a team as a code owner October 24, 2025 20:12
@hlinsen hlinsen requested review from chris-maes and nguidotti and removed request for a team October 24, 2025 20:12
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 24, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@hlinsen hlinsen added bug Something isn't working non-breaking Introduces a non-breaking change labels Oct 24, 2025
chris-maes
chris-maes approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@chris-maes chris-maes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Hugo!

@hlinsen
Copy link
Contributor Author

hlinsen commented Oct 24, 2025

/ok to test 6376963

@hlinsen
Copy link
Contributor Author

hlinsen commented Oct 24, 2025

/ok to test 1c982b2

@hlinsen
Copy link
Contributor Author

hlinsen commented Oct 27, 2025

/merge

@rapids-bot rapids-bot bot merged commit 52970a4 into NVIDIA:main Oct 27, 2025
256 of 260 checks passed
@hlinsen hlinsen mentioned this pull request Oct 29, 2025
Merged
rgsl888prabhu pushed a commit that referenced this pull request Oct 29, 2025
@hlinsen
Hot fix 25.10 (#552)
ef68d50 
Hot fix with the following commits:
- #541
- #544
- #550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rg20 rg20 rg20 approved these changes

@chris-maes chris-maes chris-maes approved these changes

@nguidotti nguidotti Awaiting requested review from nguidotti nguidotti is a code owner automatically assigned from NVIDIA/cuopt-engine-codeowners

Assignees

No one assigned

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hlinsen @rg20 @chris-maes