Skip to content

Add CTK 12.9 fatbin flags to maintain existing binary sizes #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 5 commits into from
Jul 25, 2025
Merged

Add CTK 12.9 fatbin flags to maintain existing binary sizes #58

rapids-bot merged 5 commits into from
Jul 25, 2025

Conversation

@robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented Jun 2, 2025

No description provided.

@robertmaynard robertmaynard requested a review from a team as a code owner June 2, 2025 12:48
@jakirkham
Copy link

jakirkham commented Jun 2, 2025

cc @rgsl888prabhu

@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jun 2, 2025
@rgsl888prabhu rgsl888prabhu changed the base branch from branch-25.05 to branch-25.08 June 2, 2025 16:54
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner June 2, 2025 16:54
@anandhkb anandhkb added this to the 25.08 milestone Jul 1, 2025
rgsl888prabhu
rgsl888prabhu reviewed Jul 22, 2025
View reviewed changes
Copy link
Collaborator

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertmaynard The CPP conda build is taking too long to complete (almost 45 mins), earlier it was completing in 5-10 minutes. Could it be because of compression level ?

@rgsl888prabhu
Copy link
Collaborator

rgsl888prabhu commented Jul 24, 2025

@robertmaynard The CPP conda build is taking too long to complete (almost 45 mins), earlier it was completing in 5-10 minutes. Could it be because of compression level ?

@robertmaynard minor ping on this question.

@robertmaynard
Copy link
Contributor Author

robertmaynard commented Jul 24, 2025

@robertmaynard The CPP conda build is taking too long to complete (almost 45 mins), earlier it was completing in 5-10 minutes. Could it be because of compression level ?

@robertmaynard minor ping on this question.

Since the compiler flags have changed the sccache cache is invalid and therefore everything has to recompile. If you compare clean builds before and after the compression changes you shouldn't see any significant differences.

@rgsl888prabhu
Copy link
Collaborator

rgsl888prabhu commented Jul 25, 2025

/merge

@rapids-bot rapids-bot bot merged commit 03b0143 into NVIDIA:branch-25.08 Jul 25, 2025
143 of 144 checks passed
aliceb-nv pushed a commit that referenced this pull request Jul 28, 2025
@robertmaynard @aliceb-nv
Add CTK 12.9 fatbin flags to maintain existing binary sizes (#58)
79fc52c 
Authors:
  - Robert Maynard (https://github.com/robertmaynard)
  - Ramakrishnap (https://github.com/rgsl888prabhu)

Approvers:
  - Ramakrishnap (https://github.com/rgsl888prabhu)

URL: #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

Assignees

No one assigned

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

25.08

Development

Successfully merging this pull request may close these issues.

4 participants

@robertmaynard @jakirkham @rgsl888prabhu @anandhkb