Skip to content

Conversation

@rgsl888prabhu
Copy link
Collaborator

@rgsl888prabhu rgsl888prabhu commented May 9, 2025

 Recently Solution.termination_status was changed to an enum so that we can translate between strings and ints for termination status.  When the value is set, it needs to be cast into the correct enum so that we can return the name later in Solution.get_termination_reason().
    
    Authors:
      - Trevor McKay (https://github.com/tmckayus)
    
    Approvers:
      - Rajesh Gandham (https://github.com/rg20)

This PR fixes FJ bugs (feasible solution turned infeasible, objective/violation exploding to infinity, tolerance issues, LHS numerical issues), adds some quality improvements, FJ regression tests, and the ability to save problem_t instances to a MPS file for later debugging.
    
    Authors:
      - Alice Boucher (https://github.com/aliceb-nv)
    
    Approvers:
      - Akif ÇÖRDÜK (https://github.com/akifcorduk)
      - Trevor McKay (https://github.com/tmckayus)
   Hook up MIP Gap parameters and add info about number of nodes explored and simplex iterations, other fixes (#2463)
    
    Hooks up the MIP gap absolute and relative parameters in branch and bound
    
    Returns info about the number of nodes explored and simplex iterations performed.
    
    This PR also:
    * Switches LP from returning solve time in seconds rather than milliseconds
    * Fixes an issue on degme where dual simplex not stopping when PDLP was already finished.
    * Remove mention of LPs in standard form. Since we don't require the LP to be in standard form.
FJ bug fixes, tests and improvements (#2458)
    
    This PR fixes FJ bugs (feasible solution turned infeasible, objective/violation exploding to infinity, tolerance issues, LHS numerical issues), adds some quality improvements, FJ regression tests, and the ability to save problem_t instances to a MPS file for later debugg
ing.
       
    Authors:
      - Alice Boucher (https://github.com/aliceb-nv)
    
    Approvers:
      - Akif ÇÖRDÜK (https://github.com/akifcorduk)
      - Trevor McKay (https://github.com/tmckayus)

@rgsl888prabhu rgsl888prabhu self-assigned this May 9, 2025
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner May 9, 2025 20:02
@rgsl888prabhu rgsl888prabhu added the non-breaking Introduces a non-breaking change label May 9, 2025
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner May 9, 2025 20:02
@rgsl888prabhu rgsl888prabhu added the improvement Improves an existing functionality label May 9, 2025
@rgsl888prabhu rgsl888prabhu requested review from rg20 and tmckayus May 9, 2025 20:07
Copy link
Contributor

@rg20 rg20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rgsl888prabhu
Copy link
Collaborator Author

/merge

@rgsl888prabhu rgsl888prabhu merged commit eee1a91 into NVIDIA:branch-25.05 May 10, 2025
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants