Skip to content

Conversation

@rgsl888prabhu
Copy link
Collaborator

@rgsl888prabhu rgsl888prabhu commented Jun 5, 2025

Description

This PR simplifies PR template to have 3 sections, "Description", "Issue" and "Checklist". The check list provides overview on tests and documentation with respect to changes that are part of this PR.

Issue

There is no issue created for this requirement.

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue
    • NA
  • Documentation
    • The documentation is up to date with these changes.
    • Added new documentation
    • NA

@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner June 5, 2025 15:40
@rgsl888prabhu rgsl888prabhu requested a review from bdice June 5, 2025 15:40
@rgsl888prabhu rgsl888prabhu self-assigned this Jun 5, 2025
@rgsl888prabhu rgsl888prabhu added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change labels Jun 5, 2025
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Simpler checklists are more likely to be following, in my opinion.

In the future, you might even want to consider GitHub forms: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms

Those are nice because they can make inputs mandatory.

@jameslamb jameslamb removed the request for review from bdice June 5, 2025 15:58
@rgsl888prabhu
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit ff21913 into NVIDIA:branch-25.08 Jun 5, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants