refactor(shellcheck): fix all remaining shellcheck errors/warnings #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
requested review from
Iroy30 and
jameslamb
and removed request for
a team
jameslamb
added
non-breaking
Member
|
/ok to test |
@jameslamb, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
jameslamb
approved these changes
Jun 12, 2025
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Looks like this caught a couple small bugs, nice!
Contributor
Author
|
@jameslamb -- I guess I'm not in the nvidia org? I think the bot wants a SHA after the |
Contributor
Author
|
/ok to test |
32 tasks
bdice
approved these changes
Jun 16, 2025
Contributor
|
/merge |
Contributor
|
Looks like we still need a review from @Iroy30 to get this in. Ishika, can you review? |
rgsl888prabhu
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes up the shellcheck work tracked in rapidsai/build-planning#135