[BUG]: Cannot build from source with custom CUDA location

[lahwaacz]

Version

1.0.1

Version

13.1.1

Which installation method(s) does this occur on?

Source

Describe the bug.

The Python build system does not pass the CUDA_PATH environment variable properly to the cmake command:

export CUDA_PATH=/opt/cuda
python -m build --wheel --no-isolation
...
-- Looking for CUDA Toolkit
-- No cuda.h found in /usr/local/cuda/include
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:290 (message):
  Could NOT find CUDAToolkit (missing: CUDAToolkit_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:654 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindCUDAToolkit.cmake:29 (find_package_handle_standard_args)
  CMakeLists.txt:69 (find_package)


-- Configuring incomplete, errors occurred!
error: command '/usr/bin/cmake' failed with exit code 1

ERROR Backend subprocess exited when trying to invoke build_wheel

Minimum reproducible example

Relevant log output

Full env printout

Other/Misc.

No response

Contributing Guidelines

• I agree to follow cuTile Python's contributing guidelines
• I have searched the open bugs and have found no duplicates for this bug report

[lahwaacz]

Aha, it is not due to env variables, but because you have a custom FindCUDAToolkit.cmake file in the repo.

This overrides the standard module provided by CMake, which is typically installed at /usr/share/cmake/Modules/FindCUDAToolkit.cmake. It does much better detection, see the documentation for the search behavior details: https://cmake.org/cmake/help/latest/module/FindCUDAToolkit.html

Please remove cmake/FindCUDAToolkit.cmake from the repo.

[haijieg]

With this commit, you can now pass custom cuda path using envvar CUDAToolkit_ROOT: 6503ca5

[lahwaacz]

Why do you introduce different environment variables from the CMake's upstream FindCUDAToolkit.cmake module? They have a CUDA_PATH environment variable and CUDAToolkit_ROOT CMake variable.

As I mentioned, you should just remove the cmake/FindCUDAToolkit.cmake file from the repo because the module is provided by CMake itself.